[Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102453/
-----------------------------------------------------------

(Updated Aug. 27, 2011, 11:57 a.m.)


Review request for Okular.


Changes
-------

Eh, accidentally also had change to CMakeLists.txt included, second version of diff fixed that.


Summary
-------

Or: flood code with QLatin1String/QLatin1Char

Interested in such patches? Would do more to the other files if you welcome these changes.
Have not done any measurements if this brings real advantages, but some µ-improvements should be there by theory.

Style okay? Or should resulting very long lines be broken? And should there be spaces between '('/')' and '"' ?


Diffs (updated)
-----

  core/document.cpp a417828 

Diff: http://git.reviewboard.kde.org/r/102453/diff


Testing
-------

Could still load and navigate a PDF with a toc.


Thanks,

Friedrich W. H.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110827/b98dbf2c/attachment.html>