[Okular-devel] Review Request: Append a space after each word of a selection in djvu files.

Brian Korbein bri.kor.21 at gmail.com
Mon Aug 8 04:48:53 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102250/
-----------------------------------------------------------

Review request for Okular.


Summary
-------

Append a space after each word of a selection area in djvu files. 
ddjvu_document_get_pagetext which is used to extract the text from djvu files strips any spaces from the text, storing each word in an s-exp that looks like this:
(<int>,<int>,<int>,int>,"string").
It is probably possible to reconstruct the exact spacing from the 4 coords, but just appending a space fixes the issue enough for my needs.
Fixes bug# 230787


This addresses bug 230787.
    http://bugs.kde.org/show_bug.cgi?id=230787


Diffs
-----

  generators/djvu/kdjvu.cpp 302a69b 

Diff: http://git.reviewboard.kde.org/r/102250/diff


Testing
-------

I tested using the djvu testfile included in the bug, as well as several pdfs, all of which worked as expected. There does seem to be an issue with the bug's testfile where selecting the blank space in the left margin finds an invisible word, but that seems unrelated.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110808/40339468/attachment.html>


More information about the Okular-devel mailing list