[Okular-devel] Review Request: Remove TODO and make what it is asking to do

Albert Astals Cid tsdgeos at terra.es
Fri Aug 5 22:07:36 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102220/#review5420
-----------------------------------------------------------


I wonder if we can ever end up in this code, because 

- Albert


On Aug. 5, 2011, 7:52 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102220/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 7:52 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Summary
> -------
> 
> While on the plane Albert and I, we decided to fix okular stuff.
> 
> This was something to do, hope that helps.
> 
> Deletes a resource that is never freed.
> 
> 
> Diffs
> -----
> 
>   generators/fictionbook/document.cpp e943566 
> 
> Diff: http://git.reviewboard.kde.org/r/102220/diff
> 
> 
> Testing
> -------
> 
> None, didn't have any fictionbook to try.
> 
> 
> Thanks,
> 
> Aleix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110805/74a0752a/attachment-0001.html>


More information about the Okular-devel mailing list