[Okular-devel] Review Request: Change mouse cursor when changing the current tool.

Albert Astals Cid tsdgeos at terra.es
Fri Aug 5 21:45:52 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102221/#review5418
-----------------------------------------------------------

Ship it!


Push it with this changes  to master. Thanks.


ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102221/#comment4885>

    Probably remove this todo



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/102221/#comment4886>

    Spacing in the if


- Albert


On Aug. 5, 2011, 7:59 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102221/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 7:59 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Summary
> -------
> 
> Update the cursors when changing the current mode. Addresses the problems in the bug report.
> 
> - Use a opened/closed hand for browsing.
> - Use cross for selection.
> 
> 
> This addresses bug 271816.
>     http://bugs.kde.org/show_bug.cgi?id=271816
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp f103b2f 
> 
> Diff: http://git.reviewboard.kde.org/r/102221/diff
> 
> 
> Testing
> -------
> 
> Play around with okular and see if it works as expected, which does apparently.
> 
> 
> Thanks,
> 
> Aleix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20110805/c0c65946/attachment.html>


More information about the Okular-devel mailing list