[Okular-devel] Krazy: Check for strings used improperly or should be i18n

Albert Astals Cid aacid at kde.org
Tue Mar 30 23:27:37 CEST 2010


A Dimarts, 30 de març de 2010, Glen Kaukola va escriure:
> Hey,
> 
> Here's the start of a few of krazy fixes.
> 
> This one passes QLatin1String's to QString::startsWith() and endsWith()
> methods.

I disagree with this, makes the code more difficult to read and none of that 
are hot paths so the speed improvement is not enought to justify the 
difficulty to read the code.

Rejected.

Albert


More information about the Okular-devel mailing list