[Okular-devel] [PATCH] Panning in Thumbnail List

[Albert Astals Cid]

A Dimarts, 17 de novembre de 2009, vàreu escriure:
> Hello Albert,

You forgot to CC the list ;-)

> Sorry for the delay, I was busy with other stuff lately.

No problem, we are all busy :-)

> 
> 2009/11/18 Albert Astals Cid <aacid at kde.org>:
> > A Dijous, 5 de novembre de 2009, Albert Astals Cid va escriure:
> >> A Dissabte, 17 d'octubre de 2009, Igor Stirbu va escriure:
> >> > Hello Pino,
> >> >
> >> > I've worked a bit on the issue in bug #201669. It works now for
> >> > general case but I'm sure I miss some parts that may break the
> >> > usability in okular. For example I don't use yet new DocumentViewport
> >> > instances which I suppose breaks the navigation and I didn't
> >> > understand exactly if I still need to use
> >> > VisiblePageRect.
> >> > Some of the things I still need to figure out are:
> >> >
> >> > * when dragging to top or bottom of viewable thumbnails it starts
> >> > to scroll like crazy probably due to some feature of automatically
> >> > show new thumbnails when main view is changed
> >>
> >> Yeah this is a problem we should try to fix. I think we could have a
> >>  variable telling if we are changing the viewport because of a drag and
> >> if that's happening do not do the ensureVisible in
> >> notifyViewportChanged, the problem with that is that then the view does
> >> not scroll when reaching the top/bottom "limits" and that's not what the
> >> user wants probably. My suggestion here would be scrolling the thumbnail
> >> view so that the green rectangles always are visible.
> 
> Thanks, for the hint, I'll try to see how to exploit that. Still, if
> the green rectangle
> reaches the limits a scroll effect should fire but a soft one.

Right, scrolling but not a huge scrolling.

> 
> >> > * the item->rect().size() is not a proper one. I would expect the size
> >> > to be only the preview of the page and not to include the space below
> >> > the preview which contains the page number. If you make the thumbnail
> >> > list wide enough and drag slowly from top to bottom of a thumbnail you
> >> > can see that at the bottom the mouse is not in the middle of the
> >> > yellow rectangle.
> >>
> >> I don't see this problem can you attach a screenshot?
> 
> Ok, I'll try.
> 
> >> Another problem is that you changed the behaviour on how the thumbnail
> >> list works, the old implementation let's you click anywhere inside the
> >> "green area" and drag and only moves the viewport the number of pixels
> >> you have dragged. Your implementation moves the viewport to exactly
> >> where you clicked, i think this is not what we want.
> 
> Ok, I see. I implemented that the easy way so the mouse is always in the
>  center. But is that really an usability issue. I understand that it's not
>  like the intended
> behaviour but it really a bad one? For me it seems to be natural,
> though. I'll still
> take a look at what I can do.

The idea is that you are dragging the viewport not clicking on what you want 
to see, so the delta is what matters, not the actual position of the click, 
it's like when you drag a scrollbar.

Albert

> 
> > Igor are you still working on this patch?
> 
> Sorry again for the delay.
> 
> Thanks,
> Igor
> 
> > Albert
> >
> >> Albert
> >>
> >> > Thanks,
> >> > Igor
> >>
> >> _______________________________________________
> >> Okular-devel mailing list
> >> Okular-devel at kde.org
> >> https://mail.kde.org/mailman/listinfo/okular-devel
>