[Okular-devel] Patch: (Re: Bug 148527)Wish Granted: More Zoom (initial)

[Albert Astals Cid]

A Dijous, 25 de juny de 2009, Adam Lev va escriure:
> this patch is response to Bug (Wish)
> 148527<http://bugs.kde.org/show_bug.cgi?id=148527>:
> "I want more zoom with okular "
>
>
> This patch (by myself and XTra KrazzY), as "stage one" (low performance).
> next step (halfway in) is implementing tiled rendering, this will  allow
> better
> performance (faster access) and more efficient memory usage.
>
> the improvement patch (introducing tiled rendering to okular) is on it way
> to
> be written by us and will be submitted as soon it is finished.

I'm not sure we want that without tiled rendering, but anyway here are my 
comments:
 * What out unneeded whitespace/empty lines additions, makes patches harder to 
read and make it seem you're not takin much care at creating the patch

e.g:
@@ -2656,8 +2656,10 @@
         d->blockViewport = prevState;
         // request pixmaps
         slotRequestVisiblePixmaps();
+
         // update zoom text
         updateZoomText();
+
         // update actions checked state
         if ( d->aZoomFitWidth )
         {

-    d->aZoomIn->setEnabled( d->zoomFactor < 3.9 );
+
+    d->aZoomIn->setEnabled( d->zoomFactor < MAX_ZOOM_FACTOR - 0.1 );


If you are only using a define in a file, don't put it in another, that's 
regarding MAX_ZOOM_FACTOR

Also we somehow prefer 
static const double MAX_ZOOM_FACTOR = 15.0;
to the current define.

Welcome to Okular hacking :-)

Albert