[Okular-devel] [Bug 179752] New: Fit to page, width setting is not disabled on uncheck

[David Palacio]

http://bugs.kde.org/show_bug.cgi?id=179752

           Summary: Fit to page, width setting is not disabled on uncheck
           Product: okular
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: okular-devel at kde.org
        ReportedBy: dpalacio at uninorte.edu.co


Version:           0.7.80 (using 4.1.87 (KDE 4.1.87 (KDE 4.2 >= 20090101)),
Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.26-1-amd64

After unchecking the Fit Page or Fit Width entry under the View menu Okular
keeps the previously checked behaviour active. The problem is in this section
of ui/pageview.cpp:

void PageView::slotFitToWidthToggled( bool on )
{
    if ( on ) updateZoom( ZoomFitWidth );
}

void PageView::slotFitToPageToggled( bool on )
{
    if ( on ) updateZoom( ZoomFitPage );
}


Those conditionals should have an else block as

else
{
  updateZoom( ZoomFixed );
}


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.