[Okular-devel] [PATCH] Cleanup some clutter

[Pino Toscano]

Hi,

> While I love Okular's power I always felt it was quite cluttered. Very much
> like Dolphin (my next target). The attached patch tries to clean up a few
> issues. Please let me know if I may at least commit a few of them. :)

Please be patient, and at least dropping a remainder before committing would 
have been ideal...

> 1. IMHO Okular should not show the zoom combobox in the toolbar. It looks
> weird with our new default big icons and I think that most users will never
> use anything else than "fit to width" or "fit to page". Thus, I changed the
> default to include those to buttons.

No, this is wrong. Please put back the zoom combobox, that is what the user 
expects.
The layout of the toolbar was changes so many times, and now users are used 
and familiar with the combobox. Without it, there's no way to set a 
particular zoom level.

> 2. Navigation buttons: I made them QToolButtons to match the rest of the
> buttons.

I presume the real problem is Oxygen making the normal push buttons wide as 
hell.

> 3. Frames: I removed the frame around the sidebar and let it not paint a
> background.

Removing a frame removes also the focus frame, so there is no visual freedback 
that the sidebar has focus. This should be fixed before.

> 4. let the bottom bar stretch over the full width of the app. Again less
> clutter.

The bottom part is centered to the pageview, not to the full application 
width. This way, the page control is horizontally centered wrt the page view, 
and that is better for the readability.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/okular-devel/attachments/20081121/500ee7ac/attachment.sig