[Okular-devel] [Bug 159276] Give warning on "Select All" in non-text select mode

Brad Hards bradh at frogmouth.net
Mon Dec 1 04:49:07 CET 2008


http://bugs.kde.org/show_bug.cgi?id=159276


Brad Hards bradh frogmouth net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bradh at frogmouth.net




--- Comment #1 from Brad Hards <bradh frogmouth net>  2008-12-01 04:49:06 ---
We can't really add a warning, but automatically switching to text selection
mode might be possible.

--- okular/ui/pageview.cpp      (revision 891032)
+++ okular/ui/pageview.cpp      (working copy)
@@ -718,9 +718,20 @@

 void PageView::selectAll()
 {
-    if ( d->mouseMode != MouseTextSelect )
-        return;
+    if ( d->mouseMode != MouseTextSelect ) {
+        d->aMouseTextSelect->setChecked( true );
+        d->mouseMode = MouseTextSelect;
+
+        // We can add this after the string freeze is lifted
+        // d->messageWindow->display( i18n( "Selecting all text" ),
PageViewMessage::Info, -1 );

+        // force hiding of annotator toolbar
+        if ( d->annotator )
+        {
+            d->annotator->setEnabled( false );
+        }
+    }
+
     QVector< PageViewItem * >::const_iterator it = d->items.constBegin(),
itEnd = d->items.constEnd();
     for ( ; it < itEnd; ++it )
     {

There might be a case for considering this to be a bug, rather than a feature.


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Okular-devel mailing list