[Okular-devel] new xpdf vulnerability

[Dirk Mueller]

On Wednesday, 10. January 2007 20:49, Albert Astals Cid wrote:

> > to limit the recursion depth more or less arbitrarily (e.g. no more than
> > 32 recursions). wouldn't that work as well?
> Well, that would be a bit lame and prone to break easily.

well, it is only to fix a border case. it shouldn't make the regular case any 
slower. And how is that supposed to break? It can't break more easily than 
the set based code. 

> I've improved my patch so it only looks for/adds things on the set when
> calling the recursion and compiled on release mode. That gave me similar
> time in millisecons (even the code without the patch got a higher average)
> so it seems it gets I/O "limited" and adding the patch is "free".

for excluding the I/O factors, it would be a good idea to kcachegrind it 
instead of timing it ;)


Dirk