[Nepomuk] Review Request 112476: Indexer and epubextractor: check more carefully that graphs are not empty.
Vishesh Handa
me at vhanda.in
Tue Sep 3 12:59:00 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112476/#review39261
-----------------------------------------------------------
Ship it!
You rock!
- Vishesh Handa
On Sept. 3, 2013, 7:11 a.m., Simeon Bird wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112476/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 7:11 a.m.)
>
>
> Review request for Nepomuk and Vishesh Handa.
>
>
> Description
> -------
>
> Indexer and epubextractor: check more carefully that graphs are not empty.
>
> In particular, in the indexer we check that the graph is
> non-empty, but then we remove the plain text content, so we need to
> check again.
>
> BUG: 324307
>
>
> This addresses bug 324307.
> http://bugs.kde.org/show_bug.cgi?id=324307
>
>
> Diffs
> -----
>
> services/fileindexer/indexer/epubextractor.cpp 38fb0d8158929c1ae5ed79299cce608f0dff3726
> services/fileindexer/indexer/indexer.cpp 46b5cfe1edb9924f9dc5d08b4cfe106d6515a741
>
> Diff: http://git.reviewboard.kde.org/r/112476/diff/
>
>
> Testing
> -------
>
> Tested with a file supplied by John Andersen
>
>
> Thanks,
>
> Simeon Bird
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130903/247ce6db/attachment.html>
More information about the Nepomuk
mailing list