[Nepomuk] Review Request 107730: Resource: Send custom commands over the local socket instead of dbus

Vishesh Handa me at vhanda.in
Sun May 26 21:46:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107730/
-----------------------------------------------------------

(Updated May 26, 2013, 9:46 p.m.)


Status
------

This change has been discarded.


Review request for Nepomuk and Sebastian Trueg.


Description
-------

    Resource: Send custom commands over the local socket instead of dbus
    
    We currently had a mixed system of using both dbus and sockets in the
    Resource class. It's better if we just rely on the local socket, since
    that is what the connection is there for.
    
    This is the first step that is required to move to the data-management
    commands to use the local socket instead of dbus.

This requires some custom patches in Soprano, which I'm too lazy to put up. The diff is over here http://paste.kde.org/625478/ if you really want to see.


Diffs
-----

  libnepomukcore/CMakeLists.txt 86a3aee 
  libnepomukcore/resource/commands.h PRE-CREATION 
  libnepomukcore/resource/nepomukmainmodel.h b386ab6 
  libnepomukcore/resource/nepomukmainmodel.cpp f18b545 
  libnepomukcore/resource/resourcedata.cpp 86808f8 
  libnepomukcore/resource/socketclient.h PRE-CREATION 
  libnepomukcore/resource/socketclient.cpp PRE-CREATION 
  services/storage/nepomukcore.h 4f9bed6 
  services/storage/nepomukcore.cpp 8913dcb 
  services/storage/repository.h 630b373 
  services/storage/repository.cpp 0cfc98f 

Diff: http://git.reviewboard.kde.org/r/107730/diff/


Testing
-------

works


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130526/8e3cc690/attachment.html>


More information about the Nepomuk mailing list