[Nepomuk] Review Request 106467: Virtuoso Backend: Optimize ODBC getCharData
Ignacio Serantes
kde at aynoa.net
Mon May 6 22:59:33 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106467/#review32173
-----------------------------------------------------------
backends/virtuoso/odbcqueryresult.cpp
<http://git.reviewboard.kde.org/r/106467/#comment23955>
Reading the code seems like you need a -4.
int r = SQLGetData( d->m_hstmt, colNum, SQL_C_CHAR, *buffer, bufSize-4, length );
backends/virtuoso/odbcqueryresult.cpp
<http://git.reviewboard.kde.org/r/106467/#comment23956>
And here the same:
if( *length > bufSize-4) {
- Ignacio Serantes
On Sept. 17, 2012, 11:37 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106467/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2012, 11:37 a.m.)
>
>
> Review request for Nepomuk, Soprano and Sebastian Trueg.
>
>
> Description
> -------
>
> Only use 1 SQLFetchData command in most of the cases.
>
> Callgrind stats show that 67.5% of the time in this function is spent in
> the first SQLFetchData, and an additional 27% in the second SQLGetData.
> We can avoid some of this extra cost, by only calling the function
> once.
>
> I can change the size of the default buffer if required.
>
>
> Diffs
> -----
>
> backends/virtuoso/odbcqueryresult.cpp a4f2387
>
> Diff: http://git.reviewboard.kde.org/r/106467/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130506/60eb5a8f/attachment.html>
More information about the Nepomuk
mailing list