[Nepomuk] Review Request 110301: Filewatch: move all filewatching into the filewatch service

Simeon Bird bladud at gmail.com
Sat May 4 17:52:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110301/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

Filewatch: move all filewatching into the filewatch service

Remove watch adding in the fileindexer service.
On a config change they were previously being re-added twice.

Then watch all indexed folders in filewatch constructor.
This is needed so that nepomukctl restart filewatch watches all indexed folders.
Don't bother to wait two minutes before installing the watches - it
isn't that slow anymore and we were doing most of the work anyway by
watching the homedir on startup.


Diffs
-----

  services/fileindexer/fileindexer.h 1171b1190768f89491c66b6c4540f6631ef3b4cc 
  services/fileindexer/fileindexer.cpp bd7ab6b83ced4cd02a4ffd20e85f64e52ac9acfd 
  services/filewatch/nepomukfilewatch.cpp c3e72931a218e9afc757cc3bcf51e14fc9e3689d 

Diff: http://git.reviewboard.kde.org/r/110301/diff/


Testing
-------

Compiled, ran, checked it responds to config changes correctly.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130504/47fa12df/attachment.html>


More information about the Nepomuk mailing list