[Nepomuk] Review Request 109991: Regexp cache optimization in Nepomuk fileindexer.

[Lukasz Olender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109991/
-----------------------------------------------------------

(Updated May 3, 2013, 11:11 a.m.)


Review request for Nepomuk and Vishesh Handa.


Changes
-------

Added comment into getMostCommonChars() method, changed name of private field m_newMethodInUse to m_regExpCompressionInUse (I think it'll be better), changed size_t to int and QRegExp( QString() ) into just QRegExp(). 


Description
-------

It's related with https://bugs.kde.org/show_bug.cgi?id=303654. 
P.S. I accidentally deleted author's and license info in patch. Isolated performance tests are also uploaded to http://www.sendspace.com/file/mkihdp (previous link not always work). It's my first patch.


This addresses bug 303654.
    http://bugs.kde.org/show_bug.cgi?id=303654


Diffs (updated)
-----

  common/regexpcache.h d89f968 
  common/regexpcache.cpp df45277 

Diff: http://git.reviewboard.kde.org/r/109991/diff/


Testing
-------


Thanks,

Lukasz Olender

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130503/9add8150/attachment-0001.html>