[Nepomuk] Review Request 109655: Settle the SimpleResourceModel/ResourceModel Situation
Vishesh Handa
me at vhanda.in
Mon Mar 25 11:24:47 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109655/#review29851
-----------------------------------------------------------
Sorry. It'll have to be the other way around. You need to merge the SimpleResourceModel into the ResourceModel. We need to do this because we also have a class called SimpleResource which serves a completely different purpose. We do not want to mix up the two.
- Vishesh Handa
On March 22, 2013, 12:24 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109655/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 12:24 p.m.)
>
>
> Review request for Nepomuk.
>
>
> Description
> -------
>
> Merged ResourceModel into SimpleResourceModel as discussed, and enabled the installation of the relevant header files.
>
>
> Diffs
> -----
>
> CMakeLists.txt a24dae2
> utils/resourcemodel.h 7847e76
> utils/resourcemodel.cpp c336466
> utils/searchwidget.cpp d65085f
> utils/simpleresourcemodel.h 5191ddd
> utils/simpleresourcemodel.cpp 3e9e24b
>
> Diff: http://git.reviewboard.kde.org/r/109655/diff/
>
>
> Testing
> -------
>
> Compiled and ran unit tests.
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130325/b52595a0/attachment.html>
More information about the Nepomuk
mailing list