[Nepomuk] Review Request 109552: Fix for Bug 316567 - Do not index all audio files as nmm:MusicPiece

[Jörg Ehrichs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109552/#review29396
-----------------------------------------------------------

Ship it!


Looks good

- Jörg Ehrichs


On March 17, 2013, 5:42 p.m., Ignacio Serantes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109552/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 5:42 p.m.)
> 
> 
> Review request for Nepomuk and Jörg Ehrichs.
> 
> 
> Description
> -------
> 
> If audio file has no tags then resource type is nfo:Audio instead of nmm:MusicPiece.
> 
> 
> This addresses bug 316567.
>     http://bugs.kde.org/show_bug.cgi?id=316567
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/taglibextractor.cpp ab2294a 
> 
> Diff: http://git.reviewboard.kde.org/r/109552/diff/
> 
> 
> Testing
> -------
> 
> With one mp3 and one flac audio files with tags removed using Kid3.
> 
> 
> Thanks,
> 
> Ignacio Serantes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130317/7d506e93/attachment.html>