[Nepomuk] Review Request 109398: Added support to multiple artist and genre frames in MP3, Ogg and FLAC audio files.
Commit Hook
null at kde.org
Sun Mar 17 14:31:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109398/
-----------------------------------------------------------
(Updated March 17, 2013, 2:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for Nepomuk and Vishesh Handa.
Description
-------
Some frames could be duplicated in ID3v2 and Ogg specification so I added support to duplicate artist and genre frames in MP3, Ogg and FLAC audio files.
As I'm not a C/C++ this code could be a totally mess and for sure could be optimized :).
Diffs
-----
services/fileindexer/indexer/taglibextractor.cpp a5a5ed6
Diff: http://git.reviewboard.kde.org/r/109398/diff/
Testing
-------
Tested with my music database and seems to work properly.
Thanks,
Ignacio Serantes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130317/a89d8525/attachment.html>
More information about the Nepomuk
mailing list