[Nepomuk] A nepomuk optimisation amplifying a plasma bug

[Aaron J. Seigo]

On Monday, March 11, 2013 20:37:49 Simeon Bird wrote:
> The reason this is about to become a serious problem, rather than an
> annoying graphical glitch, is that when the icon changes,
> plasma-desktop sends, via dbus, an ActivityIconChanged message to the
> ActivityManager, which goes and stores the new icon in nepomuk using
> Nepomuk2::Resource.

Some of the details here were incorrect. the Activity class in plasma-desktop 
was calling KActivities::Controller().setActivityIcon from its setIcon method, 
which causes kactivitymanagerd (kamd) to set the icon and signal the world 
about this .. which Activity was listening to, connected to its setIcon slot 
.. which would then call KActivities::Controller().setActivityIcon .. well, 
you get the picture :)

this was a hold-over from when the activity information was kept fully in 
plasma-desktop and libplasma. these days the accounting is wholey kept in kamd 
and nepomuk. the code in libplasma is deprecated (and has been removed in 
libplasma2). the code in plasma-desktop had simply not been updated.

it should now be fixed in both the KDE/4.10 and master branches .. please test 
and confirm.

cheers.

-- 
Aaron J. Seigo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130312/c92731a5/attachment.sig>