[Nepomuk] Review Request 111202: fix calculating framerate

[David Heidelberger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111202/
-----------------------------------------------------------

(Updated June 24, 2013, 7:19 p.m.)


Review request for Nepomuk and Vishesh Handa.


Changes
-------

v2: change from float to double, to fullfil qdbus requirements and prevent errors.


Description
-------

Replaced deprecated r_frame_rate [1] with avg_frame_rate. This also fix compilation with libav (where is r_frame_rate already removed)

FrameRate switched from int (23, 24, 25) to more accurate float (23.98 etc.) - recommended by libav developer. 

[1] http://lists.libav.org/pipermail/libav-devel/2012-June/029762.html


Diffs (updated)
-----

  services/fileindexer/indexer/ffmpegextractor.cpp e723e26 

Diff: http://git.reviewboard.kde.org/r/111202/diff/


Testing
-------

compilation with development libav. FFMpeg documentation is equal, so it will work.


Thanks,

David Heidelberger

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130624/0bb72bf1/attachment.html>