[Nepomuk] Review Request 111202: fix calculating framerate
Vishesh Handa
me at vhanda.in
Mon Jun 24 12:09:13 UTC 2013
> On June 24, 2013, 10:56 a.m., Vishesh Handa wrote:
> > I would like someone else to give their opinion on this.
> >
> > I find it easier for a user to view an integer as a framerate, and search along that. Eg frameRate=23 instead of frameRate=22.98. But then do people really care about searching via the framerate.
> >
> > Overall, I'm really not too sure.
>
> Dan Vrátil wrote:
> I think one usecase for floating-point frame rate is when searching for subtitles. 22.51 and 22.98 will make a difference at the end of the movie.
>
> David Heidelberger wrote:
> Well, that could be extremly useful for subtitles downloader plugins :)
Well, that's a +1. If none can come up with a negative response by tomorrow, please feel free to ship it.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111202/#review34965
-----------------------------------------------------------
On June 23, 2013, 7:34 p.m., David Heidelberger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111202/
> -----------------------------------------------------------
>
> (Updated June 23, 2013, 7:34 p.m.)
>
>
> Review request for Nepomuk and Vishesh Handa.
>
>
> Description
> -------
>
> Replaced deprecated r_frame_rate [1] with avg_frame_rate. This also fix compilation with libav (where is r_frame_rate already removed)
>
> FrameRate switched from int (23, 24, 25) to more accurate float (23.98 etc.) - recommended by libav developer.
>
> [1] http://lists.libav.org/pipermail/libav-devel/2012-June/029762.html
>
>
> Diffs
> -----
>
> services/fileindexer/indexer/ffmpegextractor.cpp e723e26
>
> Diff: http://git.reviewboard.kde.org/r/111202/diff/
>
>
> Testing
> -------
>
> compilation with development libav. FFMpeg documentation is equal, so it will work.
>
>
> Thanks,
>
> David Heidelberger
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130624/f12684de/attachment.html>
More information about the Nepomuk
mailing list