[Nepomuk] Review Request 110878: FileIndexer: Do not emit new status string when each file is done.

Commit Hook null at kde.org
Sat Jun 8 16:11:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110878/
-----------------------------------------------------------

(Updated June 8, 2013, 4:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Nepomuk and Vishesh Handa.


Description
-------

FileIndexer: Do not emit new status string when each file is done.

Since we are not showing the name of the indexed file anymore, we only
need to update the status string when it is actually done indexing,
instead of every time the file being indexed changes.

Without this patch the status string bounces constantly between "Indexing Files"
and "Scanning for changes", (because of short pauses between files being
indexed) which is distracting and unneccessary noise.


Diffs
-----

  services/fileindexer/indexscheduler.cpp 2c31cba364c21c3466325afca01d633383659eea 

Diff: http://git.reviewboard.kde.org/r/110878/diff/


Testing
-------

Compiled, ran


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130608/a123c49c/attachment-0001.html>


More information about the Nepomuk mailing list