[Nepomuk] Review Request 110794: FileIndexer: Do not attempt to index files multiple times

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110794/#review33949
-----------------------------------------------------------


This review has been submitted with commit c441198286562924ad3980527913b4888bdcb7a6 by Simeon Bird to branch master.

- Commit Hook


On June 8, 2013, 3:19 a.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110794/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 3:19 a.m.)
> 
> 
> Review request for Nepomuk, Jörg Ehrichs and Vishesh Handa.
> 
> 
> Description
> -------
> 
> FileIndexer: Do not attempt to index files multiple times
> 
> If a file indexing job fails, set kext::indexingLevel to 4, so
> that the next time the file queue fills, it is omitted.
> This means we don't burn CPU trying to index things multiple times.
> 
> Almost all of the patch is actually moving updateIndexingLevel from
> indexer/indexer.cpp to utils.cpp, and updating the build system to
> match.
> 
> REVIEW: 110794
> 
> 
> This addresses bug 315817.
>     http://bugs.kde.org/show_bug.cgi?id=315817
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexingqueue.cpp 2b119255e39fc873db08148291e1638e1a8c510a 
>   services/fileindexer/indexer/indexer.cpp 2224f9475bcb47c3aedd229beee7a13550408db5 
>   services/fileindexer/test/CMakeLists.txt 49a527f39f6f07afebf8bcd14902b63948c1c33d 
>   services/fileindexer/util.h 6814d72097b91c184500c23616e19506cf59a41f 
>   services/fileindexer/util.cpp 6f9f68e4603f70a6ae9c208f92b6ac011a34925d 
> 
> Diff: http://git.reviewboard.kde.org/r/110794/diff/
> 
> 
> Testing
> -------
> 
> Compiled, ran. No files fail to index for me now though
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130608/a8d4b8f8/attachment.html>