[Nepomuk] Review Request 110794: FileIndexer: Do not attempt to index files multiple times

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110794/
-----------------------------------------------------------

(Updated June 8, 2013, 3:19 a.m.)


Review request for Nepomuk, Jörg Ehrichs and Vishesh Handa.


Changes
-------

New version which just updates kExt::indexingLevel


Summary (updated)
-----------------

FileIndexer: Do not attempt to index files multiple times


Description (updated)
-------

FileIndexer: Do not attempt to index files multiple times

If a file indexing job fails, set kext::indexingLevel to 4, so
that the next time the file queue fills, it is omitted.
This means we don't burn CPU trying to index things multiple times.

Almost all of the patch is actually moving updateIndexingLevel from
indexer/indexer.cpp to utils.cpp, and updating the build system to
match.

REVIEW: 110794


This addresses bug 315817.
    http://bugs.kde.org/show_bug.cgi?id=315817


Diffs (updated)
-----

  services/fileindexer/fileindexingqueue.cpp 2b119255e39fc873db08148291e1638e1a8c510a 
  services/fileindexer/indexer/indexer.cpp 2224f9475bcb47c3aedd229beee7a13550408db5 
  services/fileindexer/test/CMakeLists.txt 49a527f39f6f07afebf8bcd14902b63948c1c33d 
  services/fileindexer/util.h 6814d72097b91c184500c23616e19506cf59a41f 
  services/fileindexer/util.cpp 6f9f68e4603f70a6ae9c208f92b6ac011a34925d 

Diff: http://git.reviewboard.kde.org/r/110794/diff/


Testing (updated)
-------

Compiled, ran. No files fail to index for me now though


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130608/55d9e6f1/attachment.html>