[Nepomuk] Review Request 110762: NepomukMainModel: don't crash if the backend is missing

Commit Hook null at kde.org
Wed Jun 5 15:12:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110762/
-----------------------------------------------------------

(Updated June 5, 2013, 3:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Nepomuk.


Description
-------

If creating a backend fails then 'backend' is NULL. An error is printed but initialization continues. With this patch 'virtuosoModel' is set to NULL if 'backend' is NULL instead of trying to dereference the NULL pointer. A NULL 'virtuosoModel' is valid: model() creates a dummy model in this case.


Diffs
-----

  libnepomukcore/resource/nepomukmainmodel.cpp a7c4dfd 

Diff: http://git.reviewboard.kde.org/r/110762/diff/


Testing
-------

nepomukshell and others don't crash any more. I just get lots of "Could not find virtuoso backend" errors.


Thanks,

Michael Olbrich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130605/ec0d6ad8/attachment.html>


More information about the Nepomuk mailing list