[Nepomuk] Review Request 110819: Comment the Generation of Headers for all<ResourceType>s()

Vishesh Handa me at vhanda.in
Mon Jun 3 20:17:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110819/#review33696
-----------------------------------------------------------

Ship it!


I guess you need it in KGet. Though these kind of functions really shouldn't be used. They would block for quite some time depending on how many results are being returned.

- Vishesh Handa


On June 3, 2013, 5:27 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110819/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:27 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> This should have been commented together with b3ea8cd17c926d725954dd09f30cc93dbda1181c
> 
> 
> Diffs
> -----
> 
>   rcgen/codegenerator.cpp b0f8dd7 
> 
> Diff: http://git.reviewboard.kde.org/r/110819/diff/
> 
> 
> Testing
> -------
> 
> Haven't been able to compile and test the code generator after this patch but what I would expect is that the header file will not include the all<ResourceType>s() method. Can try later if needed.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130603/6ce1f73a/attachment.html>


More information about the Nepomuk mailing list