[Nepomuk] Review Request 111513: Use parameterized ODBC queries for adding statements

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111513/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

Soprano uses only plain query strings for all operations via ODBC (Virtuoso). However, parameterized queries can provide a much better performance, especially for long string values. This patch (available in branch feature/odbcParameterizedQueries) makes Soprano use parameterized queries for addStatement at least.

This should fix the memory leaking problem with adding large plain text blobs given that addStatement is used (AFAIK the Nepomuk indexer currently uses custom queries to add the data).

Should this patch proove to be effective it should be expanded to use parameterized queries wherever possible like removeStatement. Also using prepared ODBC queries could improve the performance considerably, especially when adding a large amount of statements.


Diffs
-----

  backends/virtuoso/odbcconnection.h c87bcb7 
  backends/virtuoso/odbcconnection.cpp 754c76d 
  backends/virtuoso/virtuosomodel.cpp a884703 
  backends/virtuoso/virtuosomodel_p.h d5a86d8 

Diff: http://git.reviewboard.kde.org/r/111513/diff/


Testing
-------

Soprano tests run through smoothly. More performance and mem leakage testing needs to be done using Nepomuk.


Thanks,

Sebastian Trueg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130715/b6f63016/attachment.html>