[Nepomuk] Review Request 111202: fix calculating framerate

Vishesh Handa me at vhanda.in
Mon Jul 8 10:58:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111202/#review35728
-----------------------------------------------------------

Ship it!


:)

- Vishesh Handa


On July 8, 2013, 10:50 a.m., David Heidelberger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111202/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 10:50 a.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Replaced deprecated r_frame_rate [1] with avg_frame_rate. This also fix compilation with libav (where is r_frame_rate already removed)
> 
> FrameRate switched from int (23, 24, 25) to more accurate float (23.98 etc.) - recommended by libav developer. 
> 
> [1] http://lists.libav.org/pipermail/libav-devel/2012-June/029762.html
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/ffmpegextractor.cpp e723e26 
> 
> Diff: http://git.reviewboard.kde.org/r/111202/diff/
> 
> 
> Testing
> -------
> 
> compilation with development libav. FFMpeg documentation is equal, so it will work.
> 
> 
> Thanks,
> 
> David Heidelberger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130708/84b35130/attachment.html>


More information about the Nepomuk mailing list