[Nepomuk] Review Request 111202: fix calculating framerate

[Vishesh Handa]

> On June 25, 2013, 2:51 p.m., Ignacio Serantes wrote:
> > The best source of information I found about frame rates is this one: http://avisynth.org/mediawiki/AssumeFPS
> > 
> > but probably user will expect things like http://en.wikipedia.org/wiki/Frame_rate.
> > 
> > so I'm not really sure about what information must be stored here.
> > 
> > From a search point of view it's really easy to implement things like frameRate:24000/1001 or frameRate:23.976 or frameRate:24p but if this change is shipped, to avoid precision problems with SPARQL queries store values rounded to three decimals.
> >
> 
> Simeon Bird wrote:
>     Do people actually use frameRates other than the standard ntsc/pal values?
>     If not, could the value simply be rounded to an integer again instead of 23.976?
> 
> David Heidelberger wrote:
>     ok, for start we need fix first issue: Replaced deprecated r_frame_rate [1] with avg_frame_rate. This also fix compilation with libav (where is r_frame_rate already removed)

Makes sense. Please ship the changes which remove the deprecated values. You should however still round it to an integer.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111202/#review35060
-----------------------------------------------------------


On June 24, 2013, 7:19 p.m., David Heidelberger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111202/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 7:19 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Replaced deprecated r_frame_rate [1] with avg_frame_rate. This also fix compilation with libav (where is r_frame_rate already removed)
> 
> FrameRate switched from int (23, 24, 25) to more accurate float (23.98 etc.) - recommended by libav developer. 
> 
> [1] http://lists.libav.org/pipermail/libav-devel/2012-June/029762.html
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/ffmpegextractor.cpp e723e26 
> 
> Diff: http://git.reviewboard.kde.org/r/111202/diff/
> 
> 
> Testing
> -------
> 
> compilation with development libav. FFMpeg documentation is equal, so it will work.
> 
> 
> Thanks,
> 
> David Heidelberger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130701/03823229/attachment.html>