[Nepomuk] Review Request 108580: Editable Data should be shown at the bottom of FileMetadataWidget

[Hrvoje Senjan]

> On Jan. 25, 2013, 3:48 p.m., Vishesh Handa wrote:
> > The earlier approach was to sort all the keys and then display then. It just happens that *most*, not all, of the time it was at the bottom since the editable keys started with k (kfileitem#rating, kfileitem#tags, etc).
> > 
> > I like this approach better cause the editable data like the tagging widget is always in the same place. Since the TagWidget is something I expect the users to use a lot it would be nice if its position didn't change. It also makes for better muscle memory this way.
> > 
> > @Frank: What do you think?
> 
> Frank Reininghaus wrote:
>     First of all, thanks Hrvoje for looking into this issue!
>     
>     Looks reasoable to me - I agree that it makes sense to have the editable data always in the same place at the bottom.
> 
> Vishesh Handa wrote:
>     Hey Frank. I'm advocating it be at the top cause then it is always at the same place. With this patch, it will always be at the bottom, and the bottom position could wary based on how many other properties are displayed.
>     
>     What do you think? Should they be at the bottom or top? I would prefer them being at the top.
> 
> Frank Reininghaus wrote:
>     Hm, I'm not sure. On the one hand, I thought it makes sense to have the non-editable things (icon, name, etc.) separated from the editable ones, which is achieved by moving the editable properties to the bottom. But OTOH, you're right that the position of the editable things could vary then and might be very low. I'm not sure what the best approach is, I'm not a usability expert :-(

My reasoning was that you would first have "fixed" data, and then editable, or vice versa would also do, as Frank said in last comment. Also, from visual perspective, current layout, IMHO looks a bit strange. But, since neither of you are convinced the behavior should be changed, going to discard the review :-)


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108580/#review26175
-----------------------------------------------------------


On Jan. 25, 2013, 3:39 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108580/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 3:39 p.m.)
> 
> 
> Review request for Dolphin, Nepomuk, Frank Reininghaus, and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Provide Editable data at the bottom of the FileMetadataWidget, makes more sense, and that is the same behavior as with the old one.
> 
> 
> Diffs
> -----
> 
>   ui/filemetadataprovider.cpp 6f2a235 
> 
> Diff: http://git.reviewboard.kde.org/r/108580/diff/
> 
> 
> Testing
> -------
> 
> Compiled nepomuk-widgets with the patch, tags/ratings/comments are correctly shown after e.g. album artist/track, etc.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130127/b986d77a/attachment.html>