[Nepomuk] Review Request: Bug 262464 - dolphin interprets html in filenames/tags as html in various places

[Emmanuel Pescosta]

> On Jan. 10, 2013, 9:15 p.m., Vishesh Handa wrote:
> > Why is this being done? Wouldn't it be better to interpret the HTML tags?

> Wouldn't it be better to interpret the HTML tags?
No, I don't think so, because:

1. nonuniform appearance/naming - Compare "Change Tags" dialog with the meta-data-widget (The current meta-data-widget parses html the "Change Tags" dialog not) => tag string in meta-data-widget != tag string in dialog (I my opinion this is wrong?)

2. nonuniform behavior - Underline/Bold/Italic html tags work, but test it with <a href="/home">link</a> -> looks like a link but does not open the /home location (But the user expects it, because it looks like a link -> maybe a new bug report from a user)

What do you think? - If you think HTML tags are really the better option, then I will close this report ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108334/#review25190
-----------------------------------------------------------


On Jan. 10, 2013, 7:52 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108334/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 7:52 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Show nepomuk tag values as plain text (Do not parse html tags)
> 
> 
> This addresses bug 262464.
>     http://bugs.kde.org/show_bug.cgi?id=262464
> 
> 
> Diffs
> -----
> 
>   ui/tagcheckbox.cpp 7e402c2 
> 
> Diff: http://git.reviewboard.kde.org/r/108334/diff/
> 
> 
> Testing
> -------
> 
> Yep. See attached screenshot ;)
> 
> 
> Screenshots
> -----------
> 
> Old and new look
>   http://git.reviewboard.kde.org/r/108334/s/1019/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130110/9f3f0284/attachment.html>