[Nepomuk] Review Request: Port gwenview to using nepomuk-core

Jekyll Wu adaptee at gmail.com
Sat Jan 5 11:27:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108190/
-----------------------------------------------------------

(Updated Jan. 5, 2013, 11:27 a.m.)


Review request for Gwenview, Nepomuk and Vishesh Handa.


Changes
-------

oops, forgot to upload the patch 


Description
-------

The change is mostly done by the porting script in http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port . I just make 2 minimum change manually to make it build and (seemingly) work.

  * Remove "#include <nepomuk2/global.h>", since that header is no longer available in nepomuk-core
  * Change "find_package(Nepomuk)" to "find_package(NepomukCore)" and related parts 


PS: I'm not familiar with the code of neither gwenview nor nepomuk. I come up with this porting patch because gwenview crashes/hangs for me due to kdelibs/nepomuk from time to time ...


Diffs (updated)
-----

  CMakeLists.txt ce64825 
  app/CMakeLists.txt 6627427 
  app/filtercontroller.cpp c86ed9f 
  app/mainwindow.cpp 57f33a1 
  app/startmainpage.cpp 1141c9e 
  lib/CMakeLists.txt d3f795f 
  lib/semanticinfo/nepomuksemanticinfobackend.cpp 606214c 
  tests/auto/CMakeLists.txt 6613f4e 
  tests/auto/semanticinfobackendtest.cpp 2f670e5 

Diff: http://git.reviewboard.kde.org/r/108190/diff/


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130105/aafe1f43/attachment.html>


More information about the Nepomuk mailing list