[Nepomuk] Review Request: Nepomuk KCM: Show symlinks in "Customize Folders" as disabled items

[Gabriel Poesia]

> On Jan. 3, 2013, 11:46 a.m., Vishesh Handa wrote:
> > Seems good. I'm wondering if we should be expanding system links? Or should we just show them and not let them be selected.

I'm not sure about that either, but I think the behavior of the symlinks and the "forbidden paths" should be the same (as symlinks are forbidden in some sense, too). 
I can provide the patch to not expand them, if necessary. I guess it's enough to reimplement QAbstractItemModel::rowCount() to return 0 if the QModelIndex represents a symlink or a forbidden path.


- Gabriel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108056/#review24549
-----------------------------------------------------------


On Dec. 31, 2012, 9:33 p.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108056/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 9:33 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> When marking folders to be indexed in the KCM ("Indexing" tab, "Customize Folders" button), the user now sees the symbolic links are there, but is not allowed to mark one for indexing, nor its children. Also added a different tooltip to the symlinks, saying that these are not indexed.
> 
> 
> This addresses bug 287593.
>     http://bugs.kde.org/show_bug.cgi?id=287593
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/folderselectionmodel.h f8efb44 
>   nepomuk/kcm/folderselectionmodel.cpp 3041089 
> 
> Diff: http://git.reviewboard.kde.org/r/108056/diff/
> 
> 
> Testing
> -------
> 
> Compiled, browsed the dialog, the behavior seems consistent.
> 
> 
> Screenshots
> -----------
> 
> Appearance of the dialog when a symlink is expanded (the tooltip is shown when the mouse is hovering a symlink)
>   http://git.reviewboard.kde.org/r/108056/s/945/
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130103/0cd0758c/attachment-0001.html>