[Nepomuk] Review Request 109193: Add a new tool: nepomukctl (Nepomuk server manipulation tool)

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109193/#review28208
-----------------------------------------------------------


Wow! This is awesome!


tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21075>

    With 4.10 we now only have the following services - filewatch, fileindexer and storage.
    
    Also, other packages can ship their own services. It would be best to infer the list of service names by querying kde. Look at how the nepomukserver does it.



tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21077>

    functions should start with a lower case.



tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21076>

    Please make this into 'bool stop'. KDE Coding conventions.



tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21079>

    I'm not sure this is a good solution. I think it would be better if you checked if the service is still available via dbus, if it is, then wait for a second or so, and then check again. This could be done multiple times until the service actually shuts down.



tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21080>

    QLatin1String please :)



tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21081>

    QLatin1String again



tools/nepomukctl/main.cpp
<http://git.reviewboard.kde.org/r/109193/#comment21078>

    I would prefer if you just showed the services which are running, and not the services which are not running.


- Vishesh Handa


On Feb. 27, 2013, 3:32 p.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109193/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 3:32 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Add the NepomukCtl tool proposed in the roadmap (http://community.kde.org/Projects/Nepomuk/4.11#Nepomuk_Tools ).
> 
> This tool can start, stop or restart the Nepomuk Server or any specific service (filewatch, fileindexer, storage, backupsync or queryservice). It can also show all the running Nepomuk services.
> 
> NepomukCtl should replace the macros defined on the Techbase that serve the same purpose (http://techbase.kde.org/Projects/Nepomuk/ManagingNepomukProcesses ).
> 
> It's pretty much like akonadictl.
> 
> 
> Diffs
> -----
> 
>   tools/nepomukctl/CMakeLists.txt PRE-CREATION 
>   tools/nepomukctl/main.cpp PRE-CREATION 
>   tools/CMakeLists.txt PRE-CREATION 
>   CMakeLists.txt 7557d3e 
> 
> Diff: http://git.reviewboard.kde.org/r/109193/diff/
> 
> 
> Testing
> -------
> 
> Tested all the commands and they work.
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130227/c10bf328/attachment.html>