[Nepomuk] Review Request 109053: ResourceWatcher - Emit Resource creation signals with all the types
Jörg Ehrichs
joerg.ehrichs at gmx.de
Wed Feb 20 11:16:41 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109053/#review27783
-----------------------------------------------------------
Ship it!
Great Patch!
Together with #109055 this solves the Resourcewatcher Issue with Conquirere.
- Jörg Ehrichs
On Feb. 20, 2013, 9:20 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109053/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 9:20 a.m.)
>
>
> Review request for Nepomuk.
>
>
> Description
> -------
>
> Not just the basic types.
>
> This is done by creating a list of all the types using the
> ClassAndPropertyTree.
>
> Also added a test, and modified existing tests.
>
>
> Diffs
> -----
>
> services/storage/classandpropertytree.h 76e9eee
> services/storage/classandpropertytree.cpp b2441a9
> services/storage/datamanagementmodel.cpp af50d19
> services/storage/resourcemerger.cpp 2f8999a
> services/storage/resourcewatchermanager.h 5d0a26e
> services/storage/resourcewatchermanager.cpp 73d31c3
> services/storage/test/resourcewatchertest.h 2a0c066
> services/storage/test/resourcewatchertest.cpp 0613c40
>
> Diff: http://git.reviewboard.kde.org/r/109053/diff/
>
>
> Testing
> -------
>
> The tests pass!
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130220/7b61aaf7/attachment-0001.html>
More information about the Nepomuk
mailing list