[Nepomuk] Review Request 109044: Replay gain support for taglibextractor
Vishesh Handa
me at vhanda.in
Tue Feb 19 17:49:23 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109044/#review27734
-----------------------------------------------------------
services/fileindexer/indexer/taglibextractor.cpp
<http://git.reviewboard.kde.org/r/109044/#comment20791>
?
services/fileindexer/indexer/taglibextractor.cpp
<http://git.reviewboard.kde.org/r/109044/#comment20790>
You don't seem to be doing anything with the map once you have read it.
- Vishesh Handa
On Feb. 19, 2013, 5:10 p.m., Phalgun Guduthur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109044/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2013, 5:10 p.m.)
>
>
> Review request for Nepomuk and Vishesh Handa.
>
>
> Description
> -------
>
> Add support for the indexer to extract replay gain data.
> The code is heavily borrowed from the Amarok implementation of Taglib replay gain.
>
>
> Diffs
> -----
>
> services/fileindexer/indexer/taglibextractor.h 45baafc
> services/fileindexer/indexer/taglibextractor.cpp a5a5ed6
>
> Diff: http://git.reviewboard.kde.org/r/109044/diff/
>
>
> Testing
> -------
>
> Minimal. Code doesn't break.
>
>
> Thanks,
>
> Phalgun Guduthur
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130219/ddc8e78a/attachment.html>
More information about the Nepomuk
mailing list