[Nepomuk] Review Request 109010: Remove unnecessary function call from IgnoringKInotify::filterWatch

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109010/#review27650
-----------------------------------------------------------


This review has been submitted with commit 31ad25130d862c528a3b8dcf2000826137b8d670 by Gabriel Poesia to branch master.

- Commit Hook


On Feb. 18, 2013, 5:06 p.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109010/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 5:06 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> The IgnoringKInotify::filterWatch method, before anything else, checks if the path should be watched according to the configuration (calling FileIndexerConfig::self()->shouldFolderBeWatched( path )). If not, it returns false. But if the path should not be indexed, according to FileIndexerConfig, it returns the result of another call to "shouldFolderBeWatched", passing the same path. But this should always return true, or the method would have returned false before. Thus, the second call seems unnecessary.
> 
> 
> Diffs
> -----
> 
>   services/filewatch/nepomukfilewatch.cpp 824adca 
> 
> Diff: http://git.reviewboard.kde.org/r/109010/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130218/aa4d26f2/attachment.html>