[Nepomuk] Review Request 109010: Remove unnecessary function call from IgnoringKInotify::filterWatch

Gabriel Poesia gabriel.poesia at gmail.com
Mon Feb 18 17:06:38 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109010/
-----------------------------------------------------------

Review request for Nepomuk.


Description
-------

The IgnoringKInotify::filterWatch method, before anything else, checks if the path should be watched according to the configuration (calling FileIndexerConfig::self()->shouldFolderBeWatched( path )). If not, it returns false. But if the path should not be indexed, according to FileIndexerConfig, it returns the result of another call to "shouldFolderBeWatched", passing the same path. But this should always return true, or the method would have returned false before. Thus, the second call seems unnecessary.


Diffs
-----

  services/filewatch/nepomukfilewatch.cpp 824adca 

Diff: http://git.reviewboard.kde.org/r/109010/diff/


Testing
-------

Compiled.


Thanks,

Gabriel Poesia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130218/4afbdace/attachment.html>


More information about the Nepomuk mailing list