[Nepomuk] Review Request 108977: Check DateTime for negative years in the taglib extractor

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108977/#review27526
-----------------------------------------------------------


This review has been submitted with commit fe79c33ac37ca3484287bdf9d434151445772d58 by Simeon Bird to branch KDE/4.10.

- Commit Hook


On Feb. 15, 2013, 5:17 p.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108977/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 5:17 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> While QDateTime is perfectly happy with B.C. years, Virtuoso throws an
> SQLExecDirect error if asked to add one.
>     
> So if we encounter a year < 0, which is almost certainly a broken tag,
> replace it with year 1.
> 
> This fixes indexing on some files I had with broken tags (the year was set to 2^32-1)
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/taglibextractor.cpp 932c2567b9b142ac62cbdd16f7774d3739a6b743 
> 
> Diff: http://git.reviewboard.kde.org/r/108977/diff/
> 
> 
> Testing
> -------
> 
> Indexing files with broken tags for the year now works
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130215/dbe93e82/attachment.html>