[Nepomuk] Review Request 108962: BasicIndexingQueue: Use stacks instead of queues (take 2)

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108962/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

    BasicIndexingQueue: Use stacks instead of queues
    
    Similar to 2f33141aa6716550e38b11ec9a0b000dd74eea79, reverted by
    b651f9231ac30072418bb06d602951f0f05da22c.
    
    The reason this broke recursive indexing was that it was taking the top
    item from the stack with m_iterators.first(), but
    QStack::top() == QVector::last(). Since we no longer have m_iterators,
    anyway, we can just use a stack.
    
    Commit message from 2f33141aa:
    
    Iterating depth first will consume less memory than going breadth first.
    Also stacks are based on QVectors which avoid the unnecessary extra
    allocation in QLists.

Apply on top of Vishesh's fix for bug 310777


Diffs
-----

  services/fileindexer/basicindexingqueue.h 5d1c190 
  services/fileindexer/basicindexingqueue.cpp b581786 

Diff: http://git.reviewboard.kde.org/r/108962/diff/


Testing
-------

Recursive indexing still works! m_paths is smaller than it used to be.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130214/6d7cfdcb/attachment-0001.html>