[Nepomuk] Review Request 108916: Refactor nepomuk-simpleresource-rygen.py

[Luca Beltrame]

> On Feb. 13, 2013, 11:07 p.m., Luca Beltrame wrote:
> > services/storage/rcgen/nepomuk-simpleresource-rcgen.py, line 94
> > <http://git.reviewboard.kde.org/r/108916/diff/4/?file=113965#file113965line94>
> >
> >     Perhaps you can change the initializer as such:
> >     
> >     def __init__(self, verbose=False):
> >         [...]
> >         self.verbose = False
> >     
> >     and adjust the argparse call accordingly (see below)

I meant self.verbose=verbose actually...


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108916/#review27406
-----------------------------------------------------------


On Feb. 13, 2013, 10:57 p.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108916/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 10:57 p.m.)
> 
> 
> Review request for Nepomuk, Sebastian Trueg and Vishesh Handa.
> 
> 
> Description
> -------
> 
> To reduce to time necessary for large SimpelResource class generation for
> any application that needs more than a few ontologies.
> 
> This patch removes most calls to soprano and uses internal dictionary
> handling to generate the classes. Thus the class generation for the
> Nepomuk-WebMiner is down from ~25min to less than a second.
> 
> Instead of asking soprano for the properties/range etc of a class
> the output of the Soprano parser is used directly.
> 
> 
> Diffs
> -----
> 
>   services/storage/rcgen/nepomuk-simpleresource-rcgen.py d2a4e0c 
> 
> Diff: http://git.reviewboard.kde.org/r/108916/diff/
> 
> 
> Testing
> -------
> 
> Class output for Nepomuk-WebMiner is exactly the same just faster.
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130213/3baa081a/attachment.html>