[Nepomuk] Review Request 108916: Refactor nepomuk-simpleresource-rygen.py

[Luca Beltrame]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108916/#review27312
-----------------------------------------------------------



services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/108916/#comment20550>

    An alternative to using QStrings all around, because the Soprano.XXX.toString() methods return QStrings, is to wrap the Soprano methods in unicode() calls and use regular Python strings in the code. Of course you may need to adjust stuff like startsWith etc.



services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/108916/#comment20547>

    Nitpick (also needed for Python 3 compatiblity)
    
    class OntologyParser(object):



services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/108916/#comment20548>

    Why using set* when all you do is setting an instance attribute?
    
    You should use the instance attribute(s) directly, there is no gain from using setFoo() functions like that.


- Luca Beltrame


On Feb. 12, 2013, 11:29 a.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108916/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 11:29 a.m.)
> 
> 
> Review request for Nepomuk, Sebastian Trueg and Vishesh Handa.
> 
> 
> Description
> -------
> 
> To reduce to time necessary for large SimpelResource class generation for
> any application that needs more than a few ontologies.
> 
> This patch removes most calls to soprano and uses internal dictionary
> handling to generate the classes. Thus the class generation for the
> Nepomuk-WebMiner is down from ~25min to less than a second.
> 
> Instead of asking soprano for the properties/range etc of a class
> the output of the Soprano parser is used directly.
> 
> 
> Diffs
> -----
> 
>   services/storage/rcgen/nepomuk-simpleresource-rcgen.py d2a4e0c 
> 
> Diff: http://git.reviewboard.kde.org/r/108916/diff/
> 
> 
> Testing
> -------
> 
> Class output for Nepomuk-WebMiner is exactly the same just faster.
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130212/653a6856/attachment.html>