[Nepomuk] Review Request 105767: change export from per class to per method

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105767/#review26800
-----------------------------------------------------------


Has this been committed? It has Ship It! but still shows open in reviewboard.

- Albert Astals Cid


On July 28, 2012, 12:22 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105767/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 12:22 p.m.)
> 
> 
> Review request for Nepomuk, Sebastian Trueg and Vishesh Handa.
> 
> 
> Description
> -------
> 
> The problem this fix solves is that SyncResource derives from QMultiHash<...>. QMultiHash is a template class which normally cannot export functions, except for type independent ones (e.g. non-template methodsd). Since QMultiHash or some base class of it uses exports on some methods, one cannot export derived classes completely anymore, but one has to export each and every method. This is actually done in the attached patch.
> 
> 
> Diffs
> -----
> 
>   services/backupsync/lib/syncresource.h d19463c 
> 
> Diff: http://git.reviewboard.kde.org/r/105767/diff/
> 
> 
> Testing
> -------
> 
> on Windows only, please test on Linux!
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130206/4c7fc554/attachment.html>