[Nepomuk] Review Request 108812: Do not create dbus interface twice for FileIndexer

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108812/#review26765
-----------------------------------------------------------

Ship it!


Nice work!


services/fileindexer/fileindexer.h
<http://git.reviewboard.kde.org/r/108812/#comment20315>

    Please remove my comment. It is no longer valid.


- Vishesh Handa


On Feb. 6, 2013, 4:27 p.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108812/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 4:27 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> The dbus interface is already exported by the nepomukservice stub.
> 
> This patch removes the initialization from the fileindexer and marks all
> signal/slots that are exported as Q_SCRIPTABLE.
> 
> The interface name was changed to stick to the previous exported name
> so this patch will not break any code that already uses this interface
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexer.h afe78d7 
>   services/fileindexer/fileindexer.cpp 3ddc073 
> 
> Diff: http://git.reviewboard.kde.org/r/108812/diff/
> 
> 
> Testing
> -------
> 
> * applied patch
> * started qdbusviewer
> * everything works like before
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130206/2eb77c0c/attachment.html>