[Nepomuk] Review Request 108576: Add dbus interface to the FileWatcher for status messages

Commit Hook null at kde.org
Wed Feb 6 11:40:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108576/#review26743
-----------------------------------------------------------


This review has been submitted with commit 05d71299932c74ce989ca47d6bd7ffb81c46e730 by Jörg Ehrichs to branch master.

- Commit Hook


On Feb. 5, 2013, 9:01 p.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108576/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 9:01 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> The status of the current operation (move/remove metadata) is exported
> via dbus to show what is going on.
> 
> New dbus methods
>  * statusMessage - idle message or operation + url
>  * isUpdatingMetaData - true/false depending if something is happening
> 
> New signals
>  * matadataUpdateStarted
>  * metadataupdateStopped - only emitted if nothing happend for 5 seconds
>  * status(int status, string msg) - the integer shows idle/active state
> 
> The integer for the status signal was from akonadi_nepomuk feeder
> thus we do not need to query if the changes status message also means
> the indexer is idle/active (reduce dbus traffic)
> 
> 
> Diffs
> -----
> 
>   interfaces/org.kde.nepomuk.FileWatch.xml e2784a2 
>   services/filewatch/CMakeLists.txt 63307c0 
>   services/filewatch/metadatamover.h 6920849 
>   services/filewatch/metadatamover.cpp e771f02 
>   services/filewatch/nepomukfilewatch.h c076601 
>   services/filewatch/nepomukfilewatch.cpp ea71194 
> 
> Diff: http://git.reviewboard.kde.org/r/108576/diff/
> 
> 
> Testing
> -------
> 
> * apply patch
> * connect to signals via qdbusviewer
> * move files around
> 
> The status message is shown correctly, idle status switches correctly
> No idle status is set if many move/remove operations take place (only after all operations are finished)
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130206/4dd9c57c/attachment.html>


More information about the Nepomuk mailing list