[Nepomuk] Review Request 108724: Fix crash if the IndexCleaner finishes too fast

Vishesh Handa me at vhanda.in
Mon Feb 4 14:05:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108724/#review26614
-----------------------------------------------------------


I think this can be discarded? :)

Btw, it's nice to see you back!

- Vishesh Handa


On Feb. 2, 2013, 8:12 p.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108724/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2013, 8:12 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> When the IndexCleaner finishes, slotScheduleIndexing
> is called, which references the eventMonitor.
>     
> So we need to wait until after creating the eventMonitor to
> start the indexCleaner - otherwise we can crash if it finishes
> quickly enough.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexscheduler.cpp a13de1b 
> 
> Diff: http://git.reviewboard.kde.org/r/108724/diff/
> 
> 
> Testing
> -------
> 
> Fixes crash
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130204/490149b6/attachment.html>


More information about the Nepomuk mailing list