[Nepomuk] Review Request 108576: Add dbus interface to the FileWatcher for status messages

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108576/#review26607
-----------------------------------------------------------


Overall this is pretty good. I'm just not too fond off the idle check for 3 seconds. Maybe we have some precise started/stopped signals in the metadata-mover? That way we wouldn't need this 3 seconds timer.


services/filewatch/metadatamover.cpp
<http://git.reviewboard.kde.org/r/108576/#comment20210>

    Maybe we could have a removeUpdateStarted and removeUpdateFinished?



services/filewatch/metadatamover.cpp
<http://git.reviewboard.kde.org/r/108576/#comment20211>

    ditto



services/filewatch/nepomukfilewatch.h
<http://git.reviewboard.kde.org/r/108576/#comment20212>

    We need to find better names. We aren't really indexing anything over here. We're updating the metadata of some file.
    
    MetadataUpdateStarted?
    
    I'm not sure.



services/filewatch/nepomukfilewatch.h
<http://git.reviewboard.kde.org/r/108576/#comment20213>

    ditto



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/108576/#comment20215>

    I don't think you need to do this. It's already done by the nepomukservicestub.
    
    I could be wrong.


- Vishesh Handa


On Jan. 24, 2013, 7:15 p.m., Jörg Ehrichs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108576/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 7:15 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> The status of the current operation (move/remove metadata) is exported
> via dbus to show what is going on.
> 
> New dbus methods
>  * statusMessage - idle message or operation + url
>  * isIndexing - true/false depending if something is happening
> 
> New signals
>  * indexingStarted
>  * indexingStopped - only emitted if nothing happend for 5 seconds
>  * status(int status, string msg) - the integer shows idle/active state
> 
> The integer for the status signal was from akonadi_nepomuk feeder
> thus we do not need to query if the changes status message also means
> the indexer is idle/active (reduce dbus traffic)
> 
> 
> Diffs
> -----
> 
>   interfaces/org.kde.nepomuk.FileWatch.xml e2784a2 
>   services/filewatch/CMakeLists.txt 63307c0 
>   services/filewatch/metadatamover.h 6920849 
>   services/filewatch/metadatamover.cpp e771f02 
>   services/filewatch/nepomukfilewatch.h c076601 
>   services/filewatch/nepomukfilewatch.cpp d90ea20 
> 
> Diff: http://git.reviewboard.kde.org/r/108576/diff/
> 
> 
> Testing
> -------
> 
> * apply patch
> * connect to signals via qdbusviewer
> * move files around
> 
> The status message is shown correctly, idle status switches correctly
> No idle status is set if many move/remove operations take place (only after all operations are finished)
> 
> 
> Thanks,
> 
> Jörg Ehrichs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130204/f80bbdd1/attachment-0001.html>