[Nepomuk] Review Request 108723: fileindexer: fix taglib bitrate units

Vishesh Handa me at vhanda.in
Mon Feb 4 12:48:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108723/#review26606
-----------------------------------------------------------

Ship it!


Just checked this - http://oscaf.sourceforge.net/nfo.html#nfo:averageBitrate

Don't know why I got confused last time.

- Vishesh Handa


On Feb. 2, 2013, 6:48 p.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108723/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2013, 6:48 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> fileindexer: fix taglib bitrate units
> 
> taglib uses kbit/s for the bitrate unit, whereas nfo:averageBitrate is
> in bit/s.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/taglibextractor.cpp e6ba162a78ce2d7c1f22295226d1fdcc9b45ff3f 
> 
> Diff: http://git.reviewboard.kde.org/r/108723/diff/
> 
> 
> Testing
> -------
> 
> It still compiles.
> 
> 
> Thanks,
> 
> Edward Hades Toroshchin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130204/62c364b9/attachment.html>


More information about the Nepomuk mailing list