[Nepomuk] Review Request 108754: fileindexer: initialize objects in correct order

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108754/#review26590
-----------------------------------------------------------

Ship it!


See review 108724 :) I'm happy to abandon that one in favour of this though. 
Vishesh, is it ok to commit this to KDE 4.10?

- Simeon Bird


On Feb. 3, 2013, 5:15 p.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108754/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 5:15 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> fileindexer: initialize objects in correct order
> 
> The IndexCleaner job created in IndexScheduler could complete before
> m_eventMonitor is initialized, which leads to crash in slotCleaningDone.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexscheduler.cpp 9ab9a1c3be73cdee50aab0a5c4bb9e77ca36e069 
> 
> Diff: http://git.reviewboard.kde.org/r/108754/diff/
> 
> 
> Testing
> -------
> 
> Nepomuk file indexer runs without crash.
> 
> 
> Thanks,
> 
> Edward Hades Toroshchin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130203/a6d5cf98/attachment.html>